-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release for v1.0 #103
Draft
sbreitbart-NOAA
wants to merge
13
commits into
main
Choose a base branch
from
dev-1.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Release for v1.0 #103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove make_rda as parameter - update examples
…n and documentation
…and affiliations csvs)
….. only satf. Then updated a11y vignette to reflect where users should look for the file.
Instructions for code reviewerHello reviewer, thanks for taking the time to review this PR!
Checklist
|
…p chunk to false, re: #102 . Will change eval to true for all chunks once indices table fxn is completed.
Move post-dev0.3 changes from dev to dev-1.0 branch
-changed create_template to have rda_dir default = getwd(), and change subsequent usages of rda_dir to work with change. The fxn searches for a "rda_files" folder in rda_dir. If present, those files used in report's .qmd files. If absent, then rda files are generated and placed in the report folder. -updated documentation
…lts before generating rda files
… with results files Previous test had "fake" data file with no link - updated function relies on the data existing and not NULL in the argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the feature?